Jefffrey commented on code in PR #20045:
URL: https://github.com/apache/datafusion/pull/20045#discussion_r2736625526
##########
datafusion/functions/src/crypto/basic.rs:
##########
@@ -17,73 +17,22 @@
//! "crypto" DataFusion functions
-use arrow::array::{
- Array, ArrayRef, AsArray, BinaryArray, BinaryArrayType, StringViewArray,
-};
+use arrow::array::{Array, ArrayRef, AsArray, BinaryArray, BinaryArrayType};
use arrow::datatypes::DataType;
use blake2::{Blake2b512, Blake2s256, Digest};
use blake3::Hasher as Blake3;
-use datafusion_common::cast::as_binary_array;
use arrow::compute::StringArrayType;
-use datafusion_common::{
- DataFusionError, Result, ScalarValue, exec_err, internal_err, plan_err,
- utils::take_function_args,
-};
+use datafusion_common::{DataFusionError, Result, ScalarValue, exec_err,
plan_err};
use datafusion_expr::ColumnarValue;
use md5::Md5;
use sha2::{Sha224, Sha256, Sha384, Sha512};
use std::fmt;
use std::str::FromStr;
use std::sync::Arc;
-macro_rules! define_digest_function {
- ($NAME: ident, $METHOD: ident, $DOC: expr) => {
- #[doc = $DOC]
- pub fn $NAME(args: &[ColumnarValue]) -> Result<ColumnarValue> {
- let [data] =
take_function_args(&DigestAlgorithm::$METHOD.to_string(), args)?;
- digest_process(data, DigestAlgorithm::$METHOD)
- }
- };
-}
-define_digest_function!(
- sha224,
- Sha224,
- "computes sha224 hash digest of the given input"
-);
Review Comment:
These are unused but part of our public API; I don't see a good reason to
have them exposed so removed them
##########
datafusion/functions/src/crypto/basic.rs:
##########
@@ -17,73 +17,22 @@
//! "crypto" DataFusion functions
-use arrow::array::{
- Array, ArrayRef, AsArray, BinaryArray, BinaryArrayType, StringViewArray,
-};
+use arrow::array::{Array, ArrayRef, AsArray, BinaryArray, BinaryArrayType};
use arrow::datatypes::DataType;
use blake2::{Blake2b512, Blake2s256, Digest};
use blake3::Hasher as Blake3;
-use datafusion_common::cast::as_binary_array;
use arrow::compute::StringArrayType;
-use datafusion_common::{
- DataFusionError, Result, ScalarValue, exec_err, internal_err, plan_err,
- utils::take_function_args,
-};
+use datafusion_common::{DataFusionError, Result, ScalarValue, exec_err,
plan_err};
use datafusion_expr::ColumnarValue;
use md5::Md5;
use sha2::{Sha224, Sha256, Sha384, Sha512};
use std::fmt;
use std::str::FromStr;
use std::sync::Arc;
-macro_rules! define_digest_function {
- ($NAME: ident, $METHOD: ident, $DOC: expr) => {
- #[doc = $DOC]
- pub fn $NAME(args: &[ColumnarValue]) -> Result<ColumnarValue> {
- let [data] =
take_function_args(&DigestAlgorithm::$METHOD.to_string(), args)?;
- digest_process(data, DigestAlgorithm::$METHOD)
- }
- };
-}
-define_digest_function!(
- sha224,
- Sha224,
- "computes sha224 hash digest of the given input"
-);
-define_digest_function!(
- sha256,
- Sha256,
- "computes sha256 hash digest of the given input"
-);
-define_digest_function!(
- sha384,
- Sha384,
- "computes sha384 hash digest of the given input"
-);
-define_digest_function!(
- sha512,
- Sha512,
- "computes sha512 hash digest of the given input"
-);
-define_digest_function!(
- blake2b,
- Blake2b,
- "computes blake2b hash digest of the given input"
-);
-define_digest_function!(
- blake2s,
- Blake2s,
- "computes blake2s hash digest of the given input"
-);
-define_digest_function!(
- blake3,
- Blake3,
- "computes blake3 hash digest of the given input"
-);
-
#[derive(Debug, Copy, Clone, PartialEq, Eq, Hash)]
-pub enum DigestAlgorithm {
+pub(crate) enum DigestAlgorithm {
Review Comment:
Removed from public API
##########
datafusion/functions/src/crypto/basic.rs:
##########
@@ -269,7 +180,7 @@ impl DigestAlgorithm {
}
}
-pub fn digest_process(
+pub(crate) fn digest_process(
Review Comment:
Removed from public API
##########
datafusion/functions/src/crypto/basic.rs:
##########
@@ -135,44 +84,6 @@ impl fmt::Display for DigestAlgorithm {
}
}
-/// computes md5 hash digest of the given input
-pub fn md5(args: &[ColumnarValue]) -> Result<ColumnarValue> {
Review Comment:
Removed from public API, also moved to md5 file which is the only place its
used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
