alamb commented on code in PR #19893:
URL: https://github.com/apache/datafusion/pull/19893#discussion_r2738854504
##########
datafusion/physical-plan/src/projection.rs:
##########
@@ -498,6 +506,146 @@ impl RecordBatchStream for ProjectionStream {
}
}
+/// Describes an option immutable reference counted shared projection.
Review Comment:
I still think we should try it --
https://github.com/apache/datafusion/pull/19893#pullrequestreview-3719436520
Specotying the None type does look annoying -- maybe we could make a
version of the function that takes no projecton -- like
`try_new_without_projection` 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
