andygrove opened a new pull request, #3310: URL: https://github.com/apache/datafusion-comet/pull/3310
## Summary Closes #3309 With `native_datafusion` enabled in auto scan mode (#3307), test helpers like `usingDataSourceExec` break because they check the config string value (`native_datafusion`, `native_iceberg_compat`) but in `auto` mode the config reads as `"auto"` even though it resolves to `native_datafusion` at plan time. Since `native_comet` is deprecated and the default path is now DataSource-based, this PR inverts the logic: - Rename `usingDataSourceExec` → `usingLegacyNativeCometScan` (returns `true` only when config is explicitly `native_comet`) - Rename `usingDataSourceExecWithIncompatTypes` → `hasUnsignedSmallIntSafetyCheck` - Flip all ~40 call sites across 11 test files - Replace the explicit `SCAN_NATIVE_DATAFUSION` check in the schema evolution test with `!usingLegacyNativeCometScan` This is forward-compatible with `auto` and any future scan implementations. ## Test plan - [ ] Verify the 4 failing tests in auto mode now pass: schema evolution (x2), row group skipping (x2) - [ ] Verify no regressions in other scan modes 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
