bneradt commented on code in PR #9366:
URL: https://github.com/apache/trafficserver/pull/9366#discussion_r1145270792
##########
proxy/http2/unit_tests/test_HTTP2.cc:
##########
@@ -107,8 +107,8 @@ TEST_CASE("Convert HTTPHdr", "[HTTP2]")
// check
CHECK_THAT(buf, Catch::StartsWith("GET
https://trafficserver.apache.org/index.html HTTP/1.1\r\n"
- "Host: trafficserver.apache.org\r\n"
"User-Agent: foobar\r\n"
+ "Host: trafficserver.apache.org\r\n"
Review Comment:
I see. This doesn't look trivial to fix.
When converting from h2 to h1, we take the `:authority` header and get a
host value out of it and append a `Host:` header for the resultant HTTP/1
creation. Our `field_create` function appends and there is no corresponding
function to prepend a header. Do you know a way offhand to prepend a header
field at the beginning?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
