maskit commented on code in PR #9366:
URL: https://github.com/apache/trafficserver/pull/9366#discussion_r1145555764
##########
proxy/http2/Http2CommonSession.cc:
##########
@@ -354,7 +355,8 @@ Http2CommonSession::do_process_frame_read(int event, VIO
*vio, bool inside_frame
}
Http2ErrorCode err = Http2ErrorCode::HTTP2_ERROR_NO_ERROR;
- if (this->connection_state.get_stream_error_rate() > std::min(1.0,
Http2::stream_error_rate_threshold * 2.0)) {
+ if (this->connection_state.get_stream_error_rate() > std::min(1.0,
Http2::stream_error_rate_threshold * 2.0) &&
+ !this->is_outbound()) {
Review Comment:
Why don't you fix the code that reports the spurious errors? I don't think
we can ignore errors like this unless you can say real errors never happen in
the outbound case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
