bdgranger commented on code in PR #10565:
URL: https://github.com/apache/trafficserver/pull/10565#discussion_r1352849752
##########
proxy/http2/Http2ConnectionState.cc:
##########
@@ -522,6 +522,17 @@ rcv_rst_stream_frame(Http2ConnectionState &cstate, const
Http2Frame &frame)
"reset frame wrong length");
}
+ // Update RST_STREAM frame count per minute
+ cstate.increment_received_rst_stream_frame_count();
+ // Close this connection if its RST_STREAM frame count exceeds a limit
+ if (cstate.get_received_rst_stream_frame_count() >
Http2::max_rst_stream_frames_per_minute) {
+
HTTP2_INCREMENT_THREAD_DYN_STAT(HTTP2_STAT_MAX_RST_STREAM_FRAMES_PER_MINUTE_EXCEEDED,
this_ethread());
+ Http2StreamDebug(cstate.ua_session, stream_id, "Observed too frequent
RST_STREAM frames: %u frames within a last minute",
+ cstate.get_received_settings_frame_count());
Review Comment:
@maskit Is this a typo or copy/paste error? Shouldn't it be
get_received_rst_stream_frame_count()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
