JosiahWI commented on PR #10692:
URL: https://github.com/apache/trafficserver/pull/10692#issuecomment-1785823970

   @soumyajit11 it looks like you need to run the `clang-format` target.
   
   I see an error check, but I don't see any handling. If it's ok to ignore 
failures, then why not do:
   ```cpp
   if (result == TS_SUCCESS) {
       config->txn_slot = index;
   }
   ```
   
   But is it really ok not to handle the failure?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to