ywkaras commented on code in PR #10694:
URL: https://github.com/apache/trafficserver/pull/10694#discussion_r1384224789
##########
include/proxy/http2/Http2ServerSession.h:
##########
@@ -72,13 +72,13 @@ class Http2ServerSession : public PoolableSession, public
Http2CommonSession
void
increment_current_active_connections_stat() override
{
- Metrics::increment(http2_rsb.current_active_server_connection_count);
+
Metrics::Gauge::increment(http2_rsb.current_active_server_connection_count);
Review Comment:
If you did Counter::increment() on a gauge, you would not get a compiler
error. Since Counter::AtomicType is a base class of Gauge:AtomicType,
Gauge::AtomicType * would implicitly convert to Counter::AtomicType * .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
