masaori335 commented on code in PR #10718:
URL: https://github.com/apache/trafficserver/pull/10718#discussion_r1384412825
##########
src/iocore/cache/P_CacheVol.h:
##########
@@ -274,12 +271,18 @@ struct Stripe : public Continuation {
Stripe() : Continuation(new_ProxyMutex())
{
open_dir.mutex = mutex;
- agg_buffer = (char *)ats_memalign(ats_pagesize(), AGG_SIZE);
- memset(agg_buffer, 0, AGG_SIZE);
SET_HANDLER(&Stripe::aggWrite);
}
- ~Stripe() override { ats_free(agg_buffer); }
+ Queue<CacheVC, Continuation::Link_link> &get_pending_writers();
+ char *get_agg_buffer();
+ int get_agg_buf_pos() const;
+ void reset_agg_buf_pos();
+ int get_agg_todo_size() const;
+ void add_agg_todo(int size);
+
+private:
+ AggregateWriteBuffer write_buffer;
Review Comment:
Please add `_` as prefix to follow the naming convention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
