JosiahWI commented on code in PR #10776:
URL: https://github.com/apache/trafficserver/pull/10776#discussion_r1392974496
##########
CMakeLists.txt:
##########
@@ -697,9 +697,13 @@ add_custom_target(
COMMENT "formatting all files"
)
-if(IS_DIRECTORY ${CMAKE_SOURCE_DIR}/.git AND NOT EXISTS
${CMAKE_SOURCE_DIR}/.git/hooks/pre-commit)
- message(STATUS "Installing github hook")
+if(IS_DIRECTORY ${CMAKE_SOURCE_DIR}/.git)
+ file(TIMESTAMP ${CMAKE_SOURCE_DIR}/.git/hooks/pre-commit PRE_COMMIT_BEFORE)
configure_file(${CMAKE_SOURCE_DIR}/tools/git/pre-commit
${CMAKE_SOURCE_DIR}/.git/hooks/pre-commit COPYONLY)
Review Comment:
Does `configure_file` not always update the timestamp?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
