ywkaras commented on code in PR #10797: URL: https://github.com/apache/trafficserver/pull/10797#discussion_r1396525701
########## doc/release-notes/whats-new.en.rst: ########## @@ -58,4 +58,6 @@ using cpp:func:`Dbg` and related functions, as in |TS| core code. C++ Plugin API Deprecated ^^^^^^^^^^^^^^^^^^^^^^^^^ -It is deprecated in this release. It will be deleted in ATS 11. +It is deprecated in this release. It will be deleted in ATS 11. The ``noncopyable.h`` +header, with the ``noncopyable`` class, is deleted in this release. Use the new use of the Review Comment: Well would be nice if the rules were written down somewhere. But, to the best of my knowledge, breaking changes are permitted in a major release, with no strict requirement for deprecation. We have done deprecation first for major changes, but I don't know of any rules as to what is a major change. As they say, why put off till tomorrow what you can do today. That is, procrastination bad. Note that the compress plugin is using noncopyable, even though it does not use anything else in the C++ API. If we leave it around for another year plus, til release 11, that's more opportunity for it to be used. Kill one roach now, or a thousand later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
