bneradt commented on code in PR #10819: URL: https://github.com/apache/trafficserver/pull/10819#discussion_r1397891967
########## plugins/experimental/stek_share/stek_share.cc: ########## @@ -422,7 +422,7 @@ stek_updater(void *arg) ::pthread_setcancelstate(PTHREAD_CANCEL_ENABLE, nullptr); ::pthread_setcanceltype(PTHREAD_CANCEL_ASYNCHRONOUS, nullptr); - Dbg(dbg_ctl, "Starting STEK updater thread: %lu", ::pthread_self()); + Dbg(dbg_ctl, "Starting STEK updater thread"); Review Comment: Considering the variety of types for pthread_self, and that @duke8253 says this information is not needed, I'd still lean toward just removing the use of it in the debug log. It's not obvious to me that arbitrarily casting from the possible variety of types to an int type is safe. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
