masaori335 commented on code in PR #10952: URL: https://github.com/apache/trafficserver/pull/10952#discussion_r1432325074
########## src/iocore/cache/Store.cc: ########## @@ -486,7 +484,6 @@ Span::init(const char *path, int64_t size) } // A directory span means we will end up with a file, otherwise, we get what we asked for. - this->set_mmapable(ink_file_is_mmappable(S_ISDIR(sbuf.st_mode) ? static_cast<mode_t>(S_IFREG) : sbuf.st_mode)); Review Comment: This is setting `Span::is_mmapable_internal`, but it's used nowhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
