JosiahWI commented on code in PR #11011:
URL: https://github.com/apache/trafficserver/pull/11011#discussion_r1467880470
##########
plugins/esi/fetcher/CMakeLists.txt:
##########
@@ -16,6 +16,6 @@
#######################
add_library(fetcher STATIC HttpDataFetcherImpl.cc)
-target_link_libraries(fetcher PUBLIC esi-common libswoc)
-target_include_directories(fetcher PUBLIC "${CMAKE_CURRENT_SOURCE_DIR}")
+target_link_libraries(fetcher PUBLIC esi-common libswoc::libswoc)
+target_include_directories(fetcher PUBLIC "${CMAKE_CURRENT_SOURCE_DIR}"
"${libswoc_INCLUDE_DIRS}")
Review Comment:
We should not be both linking the target and explicitly dumping its
`INCLUDE_DIRS` into `target_include_directories`, as linking the target should
already do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
