shinrich commented on code in PR #11046:
URL: https://github.com/apache/trafficserver/pull/11046#discussion_r1484541395
##########
src/proxy/http2/Http2ClientSession.cc:
##########
@@ -191,16 +191,22 @@ Http2ClientSession::main_event_handler(int event, void
*edata)
break;
case VC_EVENT_ACTIVE_TIMEOUT:
- case VC_EVENT_INACTIVITY_TIMEOUT:
+ case VC_EVENT_INACTIVITY_TIMEOUT: {
+ if (this->connection_state.get_shutdown_state() == HTTP2_SHUTDOWN_NONE) {
+ this->connection_state.set_shutdown_state(HTTP2_SHUTDOWN_INITIATED,
Http2ErrorCode::HTTP2_ERROR_NO_ERROR);
Review Comment:
Will sending this with the SHUTDOWN_CONT event below trigger SHUTDOWN_INIT?
Or are you suggesting that this case should send the SHUTDOWN_INIT event
instead and rely on that flow to set the appropriate state?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
