cmcfarlen commented on code in PR #11239:
URL: https://github.com/apache/trafficserver/pull/11239#discussion_r1561015205
##########
src/iocore/cache/unit_tests/test_CacheVol.cc:
##########
@@ -365,6 +369,8 @@ class CacheVolTest : public CacheInit
cache_init_success_callback(int event, void *e) override
{
// Test
+ ClearCacheVolList(&cp_list, cp_list_len);
Review Comment:
Because not calling it here causes a memory leak. Turns out the structures
this cleans up are initialized before this callback is called. Global mutable
state is bad mkay?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
