bneradt commented on code in PR #11332:
URL: https://github.com/apache/trafficserver/pull/11332#discussion_r1597001954
##########
CMakePresets.json:
##########
@@ -151,7 +151,9 @@
"quiche_ROOT": "/opt/h3-tools-boringssl/quiche",
"CMAKE_INSTALL_PREFIX": "/tmp/ats-quiche",
"opentelemetry_ROOT": "/opt",
- "ENABLE_QUICHE": "ON"
+ "ENABLE_QUICHE": "ON",
+ "CMAKE_CXX_FLAGS_DEBUG": "-g -fsanitize=address",
+ "CMAKE_C_FLAGS_DEBUG": "-g -fsanitize=address"
Review Comment:
We should be able to use `"ENABLE_ASAN": "ON",` instead of setting the
flags. That would be preferable. Can you also use `ENABLE_ASAN` for the other
places in here that set those `-fsanitize=address` flags?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
