maskit commented on PR #11405: URL: https://github.com/apache/trafficserver/pull/11405#issuecomment-2148051122
The fix for `Headers::count` looks fine. However, I am not sure if we should add the operators. Because 1) this C++ API will be deprecated on version 10.0, which is going to be released in very near future (hopefully within 2 months), and b) this is a bug fix and it should be back ported to old versions. This change wouldn't break any compatibility, so technically we can add the operators to old versions, but adding anything new to 8.1.x at this time is very unusual and we'd still have to go through the API review process. Although the additions makes perfect sense, I think you could achieve the same thing without the operators by calling `name()->c_str()` and `name()->length()` if you wanted to avoid any change to the API. I'd go that way to make it a simple bug fix. But it's not a judgement call. If you think we should have the operators, you can start the API review process on the mailing list and request for feedback. https://cwiki.apache.org/confluence/display/TS/API+Review+Process -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
