cmcfarlen commented on PR #11406:
URL: https://github.com/apache/trafficserver/pull/11406#issuecomment-2149711623
Commenting out the unused argument name is already a precedent in the ATS
code and the compiler will not warn about it. There are also these defined for
use in `ink_defs.h`:
```
#define ATS_UNUSED __attribute__((unused))
#define ATS_WARN_IF_UNUSED __attribute__((warn_unused_result))
#define ATS_UNUSED_RETURN(x) \
if (x) {}
```
I think that we should reserve `[[maybe unused]]` for cases where the
argument is sometimes used depending on circumstance (constexpr or other
conditional compile). I do agree with the intent of these PRs to get the code
to where we can enable the unused parameter warning.
@maskit What say you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
