JosiahWI commented on code in PR #11452:
URL: https://github.com/apache/trafficserver/pull/11452#discussion_r1643151430
##########
src/iocore/net/TLSSessionResumptionSupport.cc:
##########
@@ -191,7 +191,7 @@ TLSSessionResumptionSupport::getSession(SSL *ssl, const
unsigned char *id, int l
}
std::shared_ptr<SSL_SESSION>
-TLSSessionResumptionSupport::getOriginSession(SSL *ssl, const std::string
&lookup_key)
+TLSSessionResumptionSupport::getOriginSession(SSL * /* ssl ATS_UNUSED */,
const std::string &lookup_key)
Review Comment:
Can we remove the `ssl` parameter?
##########
src/iocore/net/TLSSessionResumptionSupport.cc:
##########
@@ -221,12 +221,14 @@ TLSSessionResumptionSupport::clear()
#ifdef HAVE_SSL_CTX_SET_TLSEXT_TICKET_KEY_EVP_CB
int
-TLSSessionResumptionSupport::_setSessionInformation(ssl_ticket_key_block
*keyblock, SSL *ssl, unsigned char *keyname,
- unsigned char *iv,
EVP_CIPHER_CTX *cipher_ctx, EVP_MAC_CTX *hctx)
+TLSSessionResumptionSupport::_setSessionInformation(ssl_ticket_key_block
*keyblock, SSL * /* ssl ATS_UNUSED */,
Review Comment:
Here too.
##########
src/iocore/eventsystem/MIOBufferWriter.cc:
##########
@@ -76,7 +76,7 @@ MIOBufferWriter::operator>>(std::ostream &stream) const
}
ssize_t
-MIOBufferWriter::operator>>(int fd) const
+MIOBufferWriter::operator>>(int /* fd ATS_UNUSED */) const
{
return 0;
}
Review Comment:
Um... interesting. Can this whole method be removed I wonder?
##########
include/iocore/eventsystem/Lock.h:
##########
@@ -240,7 +240,7 @@ class ProxyMutex : public RefCountObj
*/
void
- init(const char *name = "UnnamedMutex")
+ init(const char * /* name ATS_UNUSED */ = "UnnamedMutex")
Review Comment:
Can the `name` parameter be removed?
##########
src/iocore/net/TLSSessionResumptionSupport.cc:
##########
@@ -221,12 +221,14 @@ TLSSessionResumptionSupport::clear()
#ifdef HAVE_SSL_CTX_SET_TLSEXT_TICKET_KEY_EVP_CB
int
-TLSSessionResumptionSupport::_setSessionInformation(ssl_ticket_key_block
*keyblock, SSL *ssl, unsigned char *keyname,
- unsigned char *iv,
EVP_CIPHER_CTX *cipher_ctx, EVP_MAC_CTX *hctx)
+TLSSessionResumptionSupport::_setSessionInformation(ssl_ticket_key_block
*keyblock, SSL * /* ssl ATS_UNUSED */,
+ unsigned char *keyname,
unsigned char *iv, EVP_CIPHER_CTX *cipher_ctx,
+ EVP_MAC_CTX *hctx)
#else
int
-TLSSessionResumptionSupport::_setSessionInformation(ssl_ticket_key_block
*keyblock, SSL *ssl, unsigned char *keyname,
- unsigned char *iv,
EVP_CIPHER_CTX *cipher_ctx, HMAC_CTX *hctx)
+TLSSessionResumptionSupport::_setSessionInformation(ssl_ticket_key_block
*keyblock, SSL * /* ssl ATS_UNUSED */,
Review Comment:
and here.
##########
src/iocore/net/SSLUtils.cc:
##########
@@ -946,7 +946,8 @@ SSLMultiCertConfigLoader::default_server_ssl_ctx()
}
static bool
-SSLPrivateKeyHandler(SSL_CTX *ctx, const SSLConfigParams *params, const char
*keyPath, const char *secret_data, int secret_data_len)
+SSLPrivateKeyHandler(SSL_CTX *ctx, const SSLConfigParams * /* params
ATS_UNUSED */, const char *keyPath, const char *secret_data,
Review Comment:
Can we remove the `params` parameter entirely?
##########
src/iocore/net/ALPNSupport.cc:
##########
@@ -98,8 +98,8 @@ ALPNSupport::advertise_next_protocol(SSL *ssl, const unsigned
char **out, unsign
}
int
-ALPNSupport::select_next_protocol(SSL *ssl, const unsigned char **out,
unsigned char *outlen, const unsigned char *in,
- unsigned inlen)
+ALPNSupport::select_next_protocol(SSL * /* ssl ATS_UNUSED */, const unsigned
char **out, unsigned char *outlen,
Review Comment:
Can the `ssl` parameter be removed?
##########
src/iocore/net/ALPNSupport.cc:
##########
@@ -88,7 +88,7 @@ ALPNSupport::setSelectedProtocol(const unsigned char *proto,
unsigned int len)
}
int
-ALPNSupport::advertise_next_protocol(SSL *ssl, const unsigned char **out,
unsigned *outlen)
+ALPNSupport::advertise_next_protocol(SSL * /* ssl ATS_UNUSED */, const
unsigned char **out, unsigned *outlen)
Review Comment:
Can the `ssl` parameter be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
