ezelkow1 commented on code in PR #11590:
URL: https://github.com/apache/trafficserver/pull/11590#discussion_r1687127738
##########
plugins/experimental/url_sig/url_sig.cc:
##########
@@ -890,7 +890,6 @@ TSRemapDoRemap(void *ih, TSHttpTxn txnp, TSRemapRequestInfo
*rri)
if (*new_path) {
TSUrlPathSet(rri->requestBufp, rri->requestUrl, new_path,
strlen(new_path));
}
- TSUrlHttpParamsSet(rri->requestBufp, rri->requestUrl, nullptr, 0);
Review Comment:
Im trying to create an autest for this first before merging. I believe what
it was doing was packing it all into 'new_path', setting the Url path, and then
removing the matrix params afterwards.
So with the old implementation would doing a ParamsSet end up re-evaluating
the path to locate the params again before removing them? I was figuring that
what it was doing was setting the Path with any included new path params and
then remove ATS' stored path params so that it would not end up being duplicated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
