brbzull0 opened a new pull request, #11654: URL: https://github.com/apache/trafficserver/pull/11654
Some default values weren't passing the validity check when ATS reads them from a `records.yaml` file This changes either the regex, or the check type to make sure the validity check don't fail when loading. This does show any error/warning unless you set them in the `records.yaml` file. Tested with the following [records.yaml](https://gist.github.com/brbzull0/deb1d8735105a1f7de27ff6091dec905) file Error when loading from a file. ``` [Aug 5 15:21:05.918] traffic_server NOTE: records parsing completed. [Aug 5 15:21:05.918] traffic_server NOTE: Warn: Warn: proxy.config.diags.logfile.rolling_min_count - Validity Check failed. '^0*[1-9][0-9]*$' against '0'. Default value will be used Warn: proxy.config.log.rolling_min_count - Validity Check failed. '^0*[1-9][0-9]*$' against '0'. Default value will be used Warn: proxy.config.output.logfile.rolling_min_count - Validity Check failed. '^0*[1-9][0-9]*$' against '0'. Default value will be used Warn: proxy.config.ssl.client.version.max - Validity Check failed. '^-?[0-9]+$' against '-1'. Default value will be used Warn: proxy.config.ssl.client.version.min - Validity Check failed. '^-?[0-9]+$' against '-1'. Default value will be used Warn: proxy.config.ssl.server.version.max - Validity Check failed. '^-?[0-9]+$' against '-1'. Default value will be used Warn: proxy.config.ssl.server.version.min - Validity Check failed. '^-?[0-9]+$' against '-1'. Default value will be used [Aug 5 15:21:05.918] traffic_server NOTE: /opt/ats/etc/trafficserver/records.yaml finished loading ``` Docs: [proxy.config.diags.logfile.rolling_min_count](https://ci.trafficserver.apache.org/job/Github_Builds/job/docs/5594/artifact/output/11648/docbuild/html/admin-guide/files/records.yaml.en.html#proxy-config-diags-logfile-rolling-min-count) [proxy.config.log.rolling_min_count ](https://ci.trafficserver.apache.org/job/Github_Builds/job/docs/5594/artifact/output/11648/docbuild/html/admin-guide/files/records.yaml.en.html#proxy-config-log-rolling-min-count) [proxy.config.output.logfile.rolling_min_count ](https://ci.trafficserver.apache.org/job/Github_Builds/job/docs/5594/artifact/output/11648/docbuild/html/admin-guide/files/records.yaml.en.html#proxy-config-output-logfile-rolling-min-count) [proxy.config.ssl.client.version.max](https://ci.trafficserver.apache.org/job/Github_Builds/job/docs/5594/artifact/output/11648/docbuild/html/admin-guide/files/records.yaml.en.html#proxy-config-ssl-client-version-max) [proxy.config.ssl.client.version.min](https://ci.trafficserver.apache.org/job/Github_Builds/job/docs/5594/artifact/output/11648/docbuild/html/admin-guide/files/records.yaml.en.html#proxy-config-ssl-client-version-min) [proxy.config.ssl.server.version.max](https://ci.trafficserver.apache.org/job/Github_Builds/job/docs/5594/artifact/output/11648/docbuild/html/admin-guide/files/records.yaml.en.html#proxy-config-ssl-server-version-max) [proxy.config.ssl.server.version.min](https://ci.trafficserver.apache.org/job/Github_Builds/job/docs/5594/artifact/output/11648/docbuild/html/admin-guide/files/records.yaml.en.html#proxy-config-ssl-server-version-min) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
