bneradt commented on code in PR #11966:
URL: https://github.com/apache/trafficserver/pull/11966#discussion_r1919158206


##########
tests/gold_tests/cache/cache-control.test.py:
##########
@@ -143,3 +143,231 @@
 tr.Processes.Default.StartBefore(server)
 tr.Processes.Default.StartBefore(ts)
 tr.AddVerifierClientProcess("proxy-verifier-client", replay_file, 
http_ports=[ts.Variables.port])
+
+#
+# Verify correct handling of various s-maxage directives in responses.
+#
+ts = Test.MakeATSProcess("ts-s-maxage")
+replay_file = "replay/cache-control-s-maxage.replay.yaml"
+server = Test.MakeVerifierServerProcess("s-maxage-server", replay_file)
+ts.Disk.records_config.update(
+    {
+        'proxy.config.diags.debug.enabled': 1,
+        'proxy.config.diags.debug.tags': 'http',
+        'proxy.config.http.insert_age_in_response': 0,
+    })
+ts.Disk.remap_config.AddLine('map / 
http://127.0.0.1:{0}'.format(server.Variables.http_port))
+tr = Test.AddTestRun("Verify correct max-age cache-control behavior.")
+tr.Processes.Default.StartBefore(server)
+tr.Processes.Default.StartBefore(ts)
+tr.AddVerifierClientProcess("s-maxage-client", replay_file, 
http_ports=[ts.Variables.port])
+
+#
+# Verify correct interaction between cache-control no-cache and pragma header
+#
+ts = Test.MakeATSProcess("ts-cache-control-pragma")
+ts.Disk.records_config.update({
+    'proxy.config.diags.debug.enabled': 1,
+    'proxy.config.diags.debug.tags': 'http|cache',
+})
+tr = Test.AddTestRun("Verify Pragma: no-cache does not conflict with 
Cache-Control headers")
+replay_file = "replay/cache-control-pragma.replay.yaml"

Review Comment:
   This looks like more than the #11601 PR:
   
   https://github.com/apache/trafficserver/pull/11601/files



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to