hnakamur commented on code in PR #12091:
URL: https://github.com/apache/trafficserver/pull/12091#discussion_r2008704281
##########
src/proxy/http/HttpSM.cc:
##########
@@ -4358,37 +4358,37 @@ HttpSM::check_sni_host()
}
int host_sni_policy = t_state.http_config_param->http_host_sni_policy;
- if (snis->would_have_actions_for(std::string{host_name,
static_cast<size_t>(host_len)}.c_str(), netvc->get_remote_endpoint(),
- host_sni_policy) &&
+ if (snis->would_have_actions_for(std::string{host_name}.c_str(),
netvc->get_remote_endpoint(), host_sni_policy) &&
host_sni_policy > 0) {
// In a SNI/Host mismatch where the Host would have triggered SNI policy,
mark the transaction
// to be considered for rejection after the remap phase passes. Gives the
opportunity to conf_remap
// override the policy to be rejected in the end_remap logic
const char *sni_value = snis->get_sni_server_name();
const char *action_value = host_sni_policy == 2 ? "terminate" : "continue";
if (!sni_value || sni_value[0] == '\0') { // No SNI
- Warning("No SNI for TLS request with hostname %.*s action=%s", host_len,
host_name, action_value);
- SMDbg(dbg_ctl_ssl_sni, "No SNI for TLS request with hostname %.*s
action=%s", host_len, host_name, action_value);
+ Warning("No SNI for TLS request with hostname %.*s action=%s", host_len,
host_name.data(), action_value);
+ SMDbg(dbg_ctl_ssl_sni, "No SNI for TLS request with hostname %.*s
action=%s", host_len, host_name.data(), action_value);
if (host_sni_policy == 2) {
swoc::bwprint(error_bw_buffer, "No SNI for TLS request: connecting to
{} for host='{}', returning a 403",
- t_state.client_info.dst_addr,
std::string_view{host_name, static_cast<size_t>(host_len)});
+ t_state.client_info.dst_addr, host_name.data());
Review Comment:
Thanks! Fixed in
[efb8ee8](https://github.com/apache/trafficserver/pull/12091/commits/efb8ee87bcb3de4be2ec5f3353a86532a28c2cde)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
