bneradt commented on code in PR #12377:
URL: https://github.com/apache/trafficserver/pull/12377#discussion_r2237909595
##########
include/cripts/Matcher.hpp:
##########
@@ -20,8 +20,10 @@
// Setup for PCRE2
#define PCRE2_CODE_UNIT_WIDTH 8
#include <pcre2.h>
+#include <algorithm>
#include <vector>
#include <tuple>
+#include <algorithm>
Review Comment:
Two `algorithm` imports.
##########
include/cripts/Headers.hpp:
##########
@@ -199,21 +163,17 @@ class Header
self_type &operator+=(const cripts::string_view str);
// These specialized assignment operators all use the above
- template <size_t N>
- self_type &
- operator=(const char (&str)[N])
- {
- return operator=(cripts::string_view(str, str[N - 1] ? N : N - 1));
- }
+ // template <size_t N>
+ // self_type &
+ // operator=(const char (&str)[N])
+ //{
+ // return operator=(cripts::string_view(str, str[N - 1] ? N : N - 1));
+ //}
Review Comment:
Maybe just remove this commented out block?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
