Copilot commented on code in PR #12465:
URL: https://github.com/apache/trafficserver/pull/12465#discussion_r2298778707
##########
src/tsutil/Regex.cc:
##########
@@ -152,8 +151,18 @@ RegexMatches::malloc(size_t size, void *caller)
return ptr;
}
- // return nullptr if buffer is too small
- return nullptr;
+ return ::malloc(size);
+}
+
+void
+RegexMatches::free(void *p, void *caller)
+{
+ auto *matches = static_cast<RegexMatches *>(caller);
+
+ // Call free for any p outside _buffer
+ if (!(p >= matches->_buffer && p < matches->_buffer +
sizeof(matches->_buffer))) {
Review Comment:
The pointer comparison logic could be unsafe if p is null. Add a null check
before performing pointer arithmetic comparisons.
##########
src/tsutil/Regex.cc:
##########
@@ -152,8 +151,18 @@ RegexMatches::malloc(size_t size, void *caller)
return ptr;
}
- // return nullptr if buffer is too small
- return nullptr;
+ return ::malloc(size);
Review Comment:
The malloc fallback doesn't handle allocation failure. Consider checking if
malloc returns nullptr and handling this error case appropriately.
```suggestion
void *ptr = ::malloc(size);
if (ptr == nullptr) {
debug_assert_message(false, "RegexMatches::malloc: malloc(%zu) failed",
size);
}
return ptr;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
