Copilot commented on code in PR #12477:
URL: https://github.com/apache/trafficserver/pull/12477#discussion_r2319426516
##########
src/cripts/Urls.cc:
##########
@@ -467,7 +467,7 @@ Pristine::URL::_initialize()
void
Client::URL::_initialize()
{
- if (_context->rri) {
+ if (_context->rri && _context->rri->requestUrl) {
Review Comment:
The null check for `requestUrl` protects line 473 but not lines 471-472
which access `requestBufp` and `requestHdrp`. If these fields can also be null
when `requestUrl` is null, they should be included in the null check or have
separate null checks.
```suggestion
if (_context->rri && _context->rri->requestBufp &&
_context->rri->requestHdrp && _context->rri->requestUrl) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
