maskit commented on code in PR #12201:
URL: https://github.com/apache/trafficserver/pull/12201#discussion_r2319465520
##########
tests/gold_tests/headers/replays/normalized_ae_varied_transactions.replay.yaml:
##########
@@ -784,11 +812,6 @@ sessions:
- [ X-Response-Identifier, { value: Br-Accept-Encoding, as: equal } ]
- [ X-Cache, { value: hit-fresh, as: equal } ]
- # NOTICE: This case should make Accept-Encoding header br, gzip;q=0.8 match
- # the alternate of br, gzip Accept-Encoding header.
- # However, due to the implementation of calculate_quality_of_match(),
- # ATS matches the alternate of gzip Accept-Encoding header.
- # The result is DIFFERENT from the description of
proxy.config.http.normalize_ae: 3
Review Comment:
This test code was provided by another contributor, and obviously I missed
this notice.
It looks like the contributor found a bug in a place they didn't touch, and
kept it as it was. The lines commented out must be the true expected results.
Since this PR uncomment those, I suppose the bug was fixed on this PR as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
