bneradt commented on code in PR #12502:
URL: https://github.com/apache/trafficserver/pull/12502#discussion_r2353087172
##########
src/iocore/net/UnixNetVConnection.cc:
##########
@@ -625,6 +625,11 @@ UnixNetVConnection::net_write_io(NetHandler *nh)
NetState *s = &this->write;
Continuation *c = this->write.vio.cont;
+ if (c == nullptr) {
+ // If Continuatin to callback is nullptr, we can do nothing
Review Comment:
Continuatin -> Continuation
##########
tests/gold_tests/h2/http2_rst_stream.test.py:
##########
@@ -58,7 +58,8 @@
tr.Processes.Default.Streams.All += Testers.ContainsExpression(
'Submitted RST_STREAM frame for key 1 on stream 1.', 'Send RST_STREAM
frame.')
-server.Streams.All += Testers.ExcludesExpression('RST_STREAM', 'Server is not
affected.')
+# NOTE: Background Fill fix changed this behavior
+# server.Streams.All += Testers.ExcludesExpression('RST_STREAM', 'Server is
not affected.')
Review Comment:
Should this be a ContainsExpression then?
##########
src/iocore/net/SSLNetVConnection.cc:
##########
@@ -897,6 +899,49 @@ SSLNetVConnection::do_io_close(int lerrno)
super::do_io_close(lerrno);
}
+void
+SSLNetVConnection::do_io_shutdown(ShutdownHowTo_t howto)
+{
+ if (get_tunnel_type() == SNIRoutingType::BLIND) {
+ // we don't have TLS layer control of blind tunnel
+ UnixNetVConnection::do_io_shutdown(howto);
+ return;
+ }
+
+ switch (howto) {
+ case IO_SHUTDOWN_READ:
+ // No need to call SSL API
Review Comment:
For the comment: probably good to explain why the API should not be called,
rather than just say it doesn't need to be called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
