bneradt commented on code in PR #12564:
URL: https://github.com/apache/trafficserver/pull/12564#discussion_r2436521091
##########
plugins/experimental/url_sig/url_sig.cc:
##########
@@ -51,8 +47,7 @@ struct config {
TSHttpStatus err_status;
char *err_url;
char keys[MAX_KEY_NUM][MAX_KEY_LEN];
- pcre *regex;
- pcre_extra *regex_extra;
+ Regex *excl_regex;
Review Comment:
Yes, I thought that too. I started making it a unique_ptr, then abandoned it
for this commit because this file is all clearly c-style. Stuff is malloc'd and
memset to zero and the like, so not constructor friendly. I'm up for changing
that, using a constructor, but was thinking if we do that it would be good to
do that as a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
