bneradt commented on PR #12544: URL: https://github.com/apache/trafficserver/pull/12544#issuecomment-3374506269
Good updates. Looks like there's a couple wrinkles to iron out though: https://ci.trafficserver.apache.org/job/Github_Builds/job/autest/31205/console ``` ../plugins/compress/configuration.cc:258:1: error: call of overloaded 'Lexicon(<brace-enclosed initializer list>)' is ambiguous 258 | }; | ^ ../plugins/compress/configuration.cc:258:1: note: there are 5 candidates In file included from ../plugins/compress/configuration.cc:36: ../lib/swoc/include/swoc/Lexicon.h:608:23: note: candidate 1: 'swoc::_1_5_14::Lexicon<E>::Lexicon(with, Default, Default) [with E = Gzip::RangeRequestCtrl; with = const std::initializer_list<swoc::_1_5_14::detail::lexicon_pair_type<Gzip::RangeRequestCtrl> >&; Default = std::variant<std::monostate, Gzip::RangeRequestCtrl, swoc::_1_5_14::TextView, std::function<Gzip::RangeRequestCtrl(swoc::_1_5_14::TextView)>, std::function<swoc::_1_5_14::TextView(Gzip::RangeRequestCtrl)> >]' 608 | template <typename E> Lexicon<E>::Lexicon(with items, Default handler_1, Default handler_2) { | ^~~~~~~~~~ ../lib/swoc/include/swoc/Lexicon.h:598:23: note: candidate 2: 'swoc::_1_5_14::Lexicon<E>::Lexicon(with_multi, Default, Default) [with E = Gzip::RangeRequestCtrl; with_multi = const std::initializer_list<swoc::_1_5_14::Lexicon<Gzip::RangeRequestCtrl>::Definition>&; Default = std::variant<std::monostate, Gzip::RangeRequestCtrl, swoc::_1_5_14::TextView, std::function<Gzip::RangeRequestCtrl(swoc::_1_5_14::TextView)>, std::function<swoc::_1_5_14::TextView(Gzip::RangeRequestCtrl)> >]' 598 | template <typename E> Lexicon<E>::Lexicon(with_multi items, Default handler_1, Default handler_2) { | ^~~~~~~~~~ In file included from ../include/ts/ts.h:39, from ../plugins/compress/configuration.h:30, from ../plugins/compress/configuration.cc:25: ../plugins/compress/configuration.cc: In static member function 'static Gzip::Configuration* Gzip::Configuration::Parse(const char*)': ../plugins/compress/debug_macros.h:48:31: error: format '%d' expects argument of type 'int', but argument 6 has type 'Gzip::ParserState' [-Werror=format=] 48 | Dbg(compress_ns::dbg_ctl, "WARNING: " fmt, ##args); \ ../include/tsutil/DbgCtl.h:169:90: note: in definition of macro 'DbgPrint' 169 | #define DbgPrint(CTL, ...) (DbgCtl::print((CTL).tag(), __FILE__, __FUNCTION__, __LINE__, __VA_ARGS__)) | ^~~~~~~~~~~ ../plugins/compress/debug_macros.h:48:5: note: in expansion of macro 'Dbg' 48 | Dbg(compress_ns::dbg_ctl, "WARNING: " fmt, ##args); \ | ^~~ ../plugins/compress/configuration.cc:414:5: note: in expansion of macro 'warning' 414 | warning("the parser state indicates that data was expected when it reached the end of the file (%d)", state); | ^~~~~~~ ../plugins/compress/configuration.cc:414:102: note: format string is defined here 414 | warning("the parser state indicates that data was expected when it reached the end of the file (%d)", state); | ~^ | | | ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
