maskit commented on code in PR #12404:
URL: https://github.com/apache/trafficserver/pull/12404#discussion_r2376690836
##########
include/proxy/http/HttpUserAgent.h:
##########
@@ -190,6 +193,14 @@ HttpUserAgent::set_txn(ProxyTransaction *txn,
TransactionMilestones &milestones)
if (auto tsrs = netvc->get_service<TLSSessionResumptionSupport>()) {
m_conn_info.ssl_reused = tsrs->getIsResumedSSLSession();
+
+ if (tsrs->getIsResumedFromSessionCache()) {
+ m_conn_info.ssl_resumption_type = 1;
+ } else if (tsrs->getIsResumedFromSessionTicket()) {
+ m_conn_info.ssl_resumption_type = 2;
+ } else {
+ m_conn_info.ssl_resumption_type = 0;
Review Comment:
Could we have an assertion that checks `m_conn_info.ssl_reused == false` ?
If yes, I think we could check the other two only if `ssl_reused` is true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
