ezelkow1 commented on code in PR #12594:
URL: https://github.com/apache/trafficserver/pull/12594#discussion_r2452179487
##########
plugins/experimental/maxmind_acl/mmdb.h:
##########
@@ -71,6 +66,20 @@ class Acl
if (db_loaded) {
MMDB_close(&_mmdb);
}
+ for (auto &i : allow_regex) {
+ for (auto &y : i.second) {
+ if (y._rex != nullptr) {
+ delete y._rex;
+ }
+ }
+ }
+ for (auto &i : deny_regex) {
+ for (auto &y : i.second) {
+ if (y._rex != nullptr) {
+ delete y._rex;
+ }
+ }
+ }
Review Comment:
Took me a while to actually remember what was going on in the parsing regex
portion. It actually has undocumented capabilities I dont remember doing. Each
rule is really supposed to be map(country-code)<regex-vector>, however it will
work with entries of [Country, Country, Regex] and add them properly, allowing
this sharing of regexes.
Contemplating if I should just fix the feature and remove that since its
undocumented as is and then would get rid of this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
