JosiahWI commented on PR #12616: URL: https://github.com/apache/trafficserver/pull/12616#issuecomment-3457991627
I don't have any issue with the code that is worth blocking a merge with, so I'm not requesting changes, but I still find it very odd that the code being benchmarked does a fixed number of iterations instead of relying on Catch2 to choose the number of iterations; that also has the effect of making the benchmarks less concise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
