Copilot commented on code in PR #310: URL: https://github.com/apache/trafficserver-ingress-controller/pull/310#discussion_r2488412052
########## Dockerfile: ########## @@ -30,7 +30,7 @@ RUN apk add --no-cache --virtual .ats-extra-build-deps --repository https://dl-c RUN apk add --no-cache --repository=https://dl-cdn.alpinelinux.org/alpine/v3.16/main libexecinfo-dev -RUN apk add --no-cache --repository=https://dl-cdn.alpinelinux.org/alpine/v3.19/main luajit-dev=2.1_p20230410-r3 +RUN apk add --no-cache --repository=https://dl-cdn.alpinelinux.org/alpine/edge/main luajit-dev=2.1_p20240815-r1 Review Comment: Using the 'edge' repository for LuaJIT introduces potential instability. The edge repository contains packages under development and may break compatibility. Consider using a stable Alpine version repository instead, or document why the edge version is required. ```suggestion RUN apk add --no-cache luajit-dev ``` ########## Dockerfile: ########## @@ -155,7 +155,7 @@ RUN apk add --no-cache -U --repository https://dl-cdn.alpinelinux.org/alpine/edg RUN apk add --no-cache --repository=https://dl-cdn.alpinelinux.org/alpine/v3.16/main libexecinfo -RUN apk add --no-cache --repository=https://dl-cdn.alpinelinux.org/alpine/v3.19/main luajit=2.1_p20230410-r3 +RUN apk add --no-cache --repository=https://dl-cdn.alpinelinux.org/alpine/edge/main luajit=2.1_p20240815-r1 Review Comment: Using the 'edge' repository for LuaJIT introduces potential instability. The edge repository contains packages under development and may break compatibility. Consider using a stable Alpine version repository instead, or document why the edge version is required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
