zwoop commented on code in PR #12201:
URL: https://github.com/apache/trafficserver/pull/12201#discussion_r2511992539


##########
src/iocore/cache/HttpTransactCache.cc:
##########
@@ -1244,7 +1244,11 @@ HttpTransactCache::CalcVariability(const 
HttpConfigAccessor *http_config_params,
 
         // Disable Vary mismatch checking for Accept-Encoding.  This is only 
safe to
         // set if you are promising to fix any 
Accept-Encoding/Content-Encoding mismatches.
-        if (http_config_params->get_ignore_accept_encoding_mismatch() &&
+        // Only suppress variability checks when the operator explicitly set

Review Comment:
   This feels like a bug that's been here for a long time. @cmcfarlen @ezelkow1 
I wonder if we should consider this for back ports to 10.x and even 9.2 ? Only 
this portion though.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to