bneradt commented on code in PR #12662: URL: https://github.com/apache/trafficserver/pull/12662#discussion_r2528096835
########## doc/developer-guide/cache-architecture/cache-initialization.en.rst: ########## @@ -77,7 +77,7 @@ stripe assignment and is called for each :class:`CacheHostRecord` and the generi stripes to be assigned are in :member:`CacheHostRecord::vols`. .. figure:: images/cache-init-cachehostrecord.png - :align: left + :align: center Review Comment: OK, exploring this further. Here's an example from this PR where what you're doing makes things **way better**: https://ci.trafficserver.apache.org/job/Github_Builds/job/docs/7948/artifact/output/12662/docbuild/html/admin-guide/layer-4-routing.en.html Compare with what we currently have where things float way right: https://docs.trafficserver.apache.org/en/latest/admin-guide/layer-4-routing.en.html Can we apply that more broadly to these various images? --- By contrast, check out these cache key images from this PR: https://ci.trafficserver.apache.org/job/Github_Builds/job/docs/7948/artifact/output/12662/docbuild/html/admin-guide/plugins/cachekey.en.html Note how they float far right. Whereas I like what we currently have better, where things float left: https://docs.trafficserver.apache.org/en/latest/admin-guide/plugins/cachekey.en.html --- If we can't do what is in the layer 4 routing more broadly easily, maybe we should just make these images float left? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
