bryancall opened a new pull request, #12689: URL: https://github.com/apache/trafficserver/pull/12689
Clang 16 and earlier don't fully support constexpr std::string operations even when __cpp_lib_constexpr_string is defined, causing static_assert failures in the compile-time tests for sanitize_metric_name_for_prometheus(). This fix uses nested ifdefs to clearly separate the feature detection from the compiler version check, disabling the constexpr optimization and compile-time tests for Clang <= 16 while keeping them enabled for GCC 13+ and future Clang versions (17+) that may have proper support. **Testing:** - ✅ Compiles successfully with Clang 16 on Rocky Linux 9 - ✅ All tests pass including test_cache_Update_Header - ✅ No linter errors - ✅ Logic is clear and future-proof -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
