bneradt commented on PR #12702:
URL: https://github.com/apache/trafficserver/pull/12702#issuecomment-3603029273

   > Sounds like `request_buffer_enabled` could be deprecated.
   
   That is possible. There's a couple points to consider here:
   
   * This feature was around before I was, but it could be that when this was 
initially implemented, it was assumed it was easier to set post_copy_size once 
to a global value (it is not currently overridable), then toggle the buffering 
via the request_buffer_enabled boolean via override. That's a line of reasoning 
I could see someone making for keeping them separate.
   * Maybe the whole feature should be deprecated in favor of transforms? With 
a transform, any plugin can do their own buffering rather than core doing it. 
Although, maybe providing the buffering as a service is helpful since manually 
buffering from a transform isn't trivial.
   
   I'm in favor of your suggestion: making `post_copy_size` overridable and 
deprecating `request_buffer_enabled`. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to