yknoya commented on code in PR #12729:
URL: https://github.com/apache/trafficserver/pull/12729#discussion_r2605045222
##########
src/proxy/http/HttpSM.cc:
##########
@@ -1823,6 +1823,9 @@ HttpSM::state_http_server_open(int event, void *data)
_netvc->do_io_write(this, 1, _netvc_reader);
_netvc->set_inactivity_timeout(this->get_server_connect_timeout());
+ // Pre-emptively set a server connect failure that will be cleared once
a WRITE_READY is received from origin or
+ // bytes are received back
+ t_state.set_connect_fail(EIO);
Review Comment:
Thanks for the review.
I also thought it would be better to set `EIO` only when an actual error is
detected, but due to time constraints I applied the current workaround-like
approach.
I'll look into whether that approach is feasible, so please give me a little
time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
