zwoop commented on code in PR #12476:
URL: https://github.com/apache/trafficserver/pull/12476#discussion_r2608158203
##########
.gitignore:
##########
@@ -170,7 +170,6 @@ rc/trafficserver.service
.libs/
.svn/
-.vscode/
Review Comment:
I'd prefer not removing this, I have quite a few files in my .vscode :)
##########
plugins/CMakeLists.txt:
##########
@@ -16,6 +16,7 @@
#######################
include(add_atsplugin)
+include(add_cript)
Review Comment:
I think, but not certain (i'm not a cmake expert) that this is redundant.
##########
include/cripts/Epilogue.hpp:
##########
@@ -752,10 +752,12 @@ TSPluginInit(int argc, const char *argv[])
inst->NeedCallback(enabled_txn_hooks);
TSContDataSet(contp, context);
TSHttpHookAdd(TS_HTTP_TXN_START_HOOK, contp); // This acts similarly to
the DoRemap callback
+ } else if (needs_glb_init) {
Review Comment:
I don't remember much of this code, but would this not leak the context and
inst now ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
