Copilot commented on code in PR #12742:
URL: https://github.com/apache/trafficserver/pull/12742#discussion_r2620690116
##########
tests/gold_tests/pluginTest/xdebug/x_probe_full_json/x_probe_full_json.replay.yaml:
##########
@@ -117,7 +117,7 @@ sessions:
- [ X-Response, "binary-data" ]
content:
encoding: plain
- data: "Binary data with quotes!"
+ data: '"Binary data with quotes!"'
Review Comment:
The binary data content has been changed from plain text to a quoted string,
which alters the actual binary content being tested. This changes the hex
encoding and may not accurately test the original binary data scenario. The
quotes should be removed to preserve the original test intent.
```suggestion
data: Binary data with quotes!
```
##########
tests/gold_tests/pluginTest/xdebug/x_probe_full_json/x_probe_full_json.replay.yaml:
##########
@@ -128,5 +128,44 @@ sessions:
- [ X-Original-Content-Type, { value: "application/octet-stream", as:
equal } ]
content:
# Expect hex encoding: "Binary data with quotes!" -> hex
- data: '42696e617279206461746120776974682071756f74657321'
+ data: '"2242696e617279206461746120776974682071756f7465732122",'
Review Comment:
The expected hex output includes leading and trailing quote characters (22
hex = double quote) that were not in the original test data. The hex string
should represent only 'Binary data with quotes!' without the added surrounding
quotes, unless the source data at line 120 is corrected to remove its added
quotes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
