maskit commented on PR #12748: URL: https://github.com/apache/trafficserver/pull/12748#issuecomment-3663231424
> My understanding is that is_outbound_connection represents communication with origin which in case of receiving frame means response from origin I assumed that server_request field would be set since the previous condition ensure that we are at the response step and consequently, the request was created and sent. Correct. > I think the same fields can be used to know if the frame is part of a response to a conditional GET request, however to find the http status code seems trickier since the response headers are not parsed yet as we just received the frame and are still validating it. `stream->decode_header_blocks` is called before `!stream->payload_length_is_valid()` in `rcv_headers_frame` and rcv_continuation_frame. The status code should be available. But if I'm missing something and it's tricky, I'm fine with fixing just the HEAD request case. The proposed condition looks fine. Since those are accessible from `stream`, I think you can use the condition in `payload_length_is_valid`. And then it should work for rcv_data_frame as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
