bneradt commented on code in PR #12767:
URL: https://github.com/apache/trafficserver/pull/12767#discussion_r2653349947
##########
include/proxy/http2/Http2Stream.h:
##########
@@ -209,10 +209,14 @@ class Http2Stream : public ProxyTransaction
Http2StreamState _state = Http2StreamState::HTTP2_STREAM_STATE_IDLE;
int64_t _http_sm_id = -1;
- HTTPHdr _receive_header;
+ HTTPHdr _receive_header;
+#if TS_USE_MALLOC_ALLOCATOR
+ MIOBuffer _receive_buffer{BUFFER_SIZE_INDEX_FOR_XMALLOC_SIZE(4096)};
+#else
MIOBuffer _receive_buffer{BUFFER_SIZE_INDEX_4K};
- VIO read_vio;
- VIO write_vio;
+#endif
Review Comment:
Can `HTTP2_HEADER_BUFFER_SIZE_INDEX` be constexpr so that `_receive_buffer`
is allocated with that value? Or do compilers not like that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
