masaori335 commented on code in PR #12791: URL: https://github.com/apache/trafficserver/pull/12791#discussion_r2670620545
########## src/iocore/cache/StripeSM.h: ########## @@ -60,6 +60,56 @@ struct StripeInitInfo; class CacheEvacuateDocVC; class RamCache; +/** + @class StripeSM + + @startuml + hide empty description + + [*] --> aggWrite : Constructor + + note right of aggWrite + Can be called: + 1. As handler (event system) + 2. Directly from CacheVC::handleWrite + 3. Directly from CacheSync::mainEvent + 4. Directly from aggWriteDone + end note + + aggWrite --> aggWriteDone + + note bottom of aggWriteDone + calls aggWrite() directly + without changing state Review Comment: This is a pitfall. Change the state back to `aggWrite` before calling it seems better to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
