zwoop commented on code in PR #12917:
URL: https://github.com/apache/trafficserver/pull/12917#discussion_r2880913333
##########
src/records/RecConfigParse.cc:
##########
@@ -123,7 +123,7 @@ RecConfigOverrideFromEnvironment(const char *name, const
char *value)
if (envval) {
return envval;
} else if (RecConfigOverrideFromRunroot(name)) {
- return nullptr;
Review Comment:
Why this else if ? you return "value" regardless of the value of
RecConfigOverrideFromRunroot(name)), no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
