moonchen commented on code in PR #12937:
URL: https://github.com/apache/trafficserver/pull/12937#discussion_r2885662304
##########
src/proxy/http/HttpSM.cc:
##########
@@ -7732,11 +7732,14 @@ HttpSM::kill_this()
void
HttpSM::update_stats()
{
- ATS_PROBE1(milestone_sm_finish, sm_id);
+ const HTTPStatus status_code =
+ t_state.hdr_info.client_response.valid() ?
t_state.hdr_info.client_response.status_get() : HTTPStatus::NONE;
+
+ ATS_PROBE2(milestone_sm_finish, sm_id, static_cast<int>(status_code));
Review Comment:
The example demonstrates the use of sm_id. It doesn't need to use
status_code, and the bpftrace code should keep working as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
