bryancall opened a new pull request, #12946:
URL: https://github.com/apache/trafficserver/pull/12946
The documentation for the compress plugin's `cache` option incorrectly
described
the behavior of `cache true` and `cache false`.
* **Fix `cache` option description** -- the docs stated that `cache true`
causes
both compressed and uncompressed versions to be cached as alternates. In
reality, `cache true` caches only the compressed (transformed) response,
and
`cache false` caches only the uncompressed (untransformed) response with
on-the-fly compression from cache. The `Vary: Accept-Encoding` header
(added
by the plugin to all compressible responses) is what creates separate
alternates for different client types.
* **Fix default behavior description** -- updated the default behavior bullet
to accurately reflect that compressed responses are cached, with alternates
maintained via `Vary: Accept-Encoding`.
* **Fix sample config comment** -- updated `sample.compress.config` to match
the corrected description.
Verified by code review of `compress.cc` lines 792-801
(`compress_transform_add`)
and live testing on ATS 11.0.0 (ASAN build). Both `cache true` and `cache
false`
were tested with gzip and non-gzip clients, confirming the actual caching
behavior
matches the updated documentation.
Fixes: #8989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
