bryancall commented on code in PR #13013:
URL: https://github.com/apache/trafficserver/pull/13013#discussion_r2981991017
##########
plugins/experimental/ja4_fingerprint/plugin.cc:
##########
@@ -444,7 +444,7 @@ handle_vconn_close(TSCont /* cont ATS_UNUSED */, TSEvent
event, void *edata)
return TS_SUCCESS;
}
TSVConn const ssl_vc{static_cast<TSVConn>(edata)};
- delete static_cast<std::string *>(TSUserArgGet(ssl_vc,
*get_user_arg_index()));
+ delete static_cast<JA4_data *>(TSUserArgGet(ssl_vc, *get_user_arg_index()));
TSUserArgSet(ssl_vc, *get_user_arg_index(), nullptr);
Review Comment:
Fixed — handle_read_request_hdr now retrieves JA4_data* and passes
&data->fingerprint to append_JA4_headers. Addressed in latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
