cmcfarlen commented on code in PR #13022:
URL: https://github.com/apache/trafficserver/pull/13022#discussion_r2995167801
##########
include/mgmt/rpc/jsonrpc/json/YAMLCodec.h:
##########
@@ -193,8 +193,10 @@ class yamlcpp_json_encoder
json << YAML::Key << "data";
json << YAML::BeginSeq;
for (auto const &err : errata) {
+ int severity = err.severity(ERRATA_DIAG);
json << YAML::BeginMap;
- json << YAML::Key << "code" << YAML::Value << errata.code().value();
+ // using "code" as the key here because this is decoded into a
`JSONRPCError`
+ json << YAML::Key << "code" << YAML::Value << severity;
Review Comment:
The Annotation class doesn't have code, only severity and text.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
